Conversation
lqiu96
changed the title
|
lqiu96
commented
Mar 13, 2025
| # help speed up the execution as building the entire repo is an expensive operation. Specify the nested | ||
| # `google-cloud-*` path (except for grafeas as it doesn't have one) because maven -pl will only build the | ||
| # specified folder (i.e. parent folder) and ignore all the related sub-modules inside | ||
| google_cloud_java_handwritten_maven_args="java-grafeas,java-vertexai/google-cloud-vertexai,java-resourcemanager/google-cloud-resourcemanager,java-translate/google-cloud-translate" |
Member
Author
There was a problem hiding this comment.
This has the handwritten modules written out again. This is separate from the list in the binary script as this also includes the proto modules.
|
blakeli0
approved these changes
Mar 14, 2025
Contributor
I think this is acceptable to be run on each PR now, since the slowest CI takes around 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run from this speed-up for google-cloud-java: https://github.com/googleapis/sdk-platform-java/actions/runs/13845404432/job/38742611238
Google-cloud-java is able to run linkage checker on the handwritten modules in ~4 min. Slowest is now bigquerystorage that runs in ~10 min